Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java/Spring] Revert to fully qualified import for org.springframework.core.io.Resource #11461

Merged

Conversation

cachescrubber
Copy link
Contributor

@cachescrubber cachescrubber commented Jan 30, 2022

Last Minute correction:

Revert to fully qualified import for org.springframework.core.io.Resource

On final Decision:

Springdoc (OAS3) is the default Documentation Provider since (#11258)

Should we set it to Springfox (OAS2) for 5.4.0, switching the default in 6.0?

PR checklist

  • [x ] Read the contribution guidelines.
  • [ x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cachescrubber
Copy link
Contributor Author

@wing328 FYI

@cachescrubber
Copy link
Contributor Author

@welshm What do you think should be the default in 5.4.0?

@welshm
Copy link
Contributor

welshm commented Jan 30, 2022

@welshm What do you think should be the default in 5.4.0?

IMO I would default to OAS2 / SpringFox for backwards compatibility and change the default in 6.0.

Easy enough for people who want it to set the correct configurations and doesn't break people who just want stability improvements from the generator update

@wing328
Copy link
Member

wing328 commented Jan 31, 2022

Springdoc (OAS3) is the default Documentation Provider since (#11258)

5.4.0 allows breaking changes with fallback so it's ok to do so

@wing328 wing328 changed the title [Java/Spring] prepare release 5.4.0 [Java/Spring] Revert to fully qualified import for org.springframework.core.io.Resource Jan 31, 2022
@wing328 wing328 added this to the 5.4.0 milestone Jan 31, 2022
@wing328 wing328 merged commit b261b29 into OpenAPITools:master Jan 31, 2022
@cachescrubber
Copy link
Contributor Author

Ok, then we go for Springdoc (OAS3).

@cachescrubber cachescrubber deleted the feature/spring_prepre_release_540 branch January 31, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants